feat: apply CipherSuites to sing-box TLS outbounds - #4
Merged
Conversation
sing-box supports cipher_suites on outbound TLS (a list of the same Go TLS names Xray takes as a colon-separated string), so the setting no longer silently does nothing when a profile runs on the sing-box core. Add cipher_suites to Tls4Sbox and map it in GenOutboundTls for the TLS branch only (REALITY uses uTLS where cipher suites do not apply), splitting the stored string on ":" or ",". Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up a commit stranded on
feat/cipher-suites-share-link: it was pushed right after #3 had already been merged, so it never landed in master (same situation as patterniha/PattNG#3 earlier).What changed
sing-box supports
cipher_suiteson outbound TLS — a list of the same Go TLS names that Xray takes as a colon-separated string — so theCipherSuitessetting no longer silently does nothing when a profile runs on the sing-box core (including TUIC/Anytls, where the field is editable).Tls4Sbox: newcipher_suitesfield.SingboxOutboundService.GenOutboundTls: maps the stored string (split on:or,) in the TLS branch only; REALITY uses uTLS, where cipher suites don't apply.Per sing-box docs, TLS 1.3 cipher suites are not configurable and the option is ignored for them; that's inherent to the option.
ServiceLibbuilds cleanly with this change (0 warnings, 0 errors).🤖 Generated with Claude Code